Fix CUDA tensor to numpy conversion error in apply_grappa_kernel#10
Open
ramintoosi wants to merge 1 commit into
Open
Fix CUDA tensor to numpy conversion error in apply_grappa_kernel#10ramintoosi wants to merge 1 commit into
ramintoosi wants to merge 1 commit into
Conversation
ramintoosi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
sigis on CUDA,nonzero()[0]returns a CUDA tensor.Unpacking it into
shift_y, shift_zgives CUDA scalars, whichthen fail when added to a numpy array on line 84 (
zival = cnt + z_ival).Fix: add
.cpu()to move the tensor to CPU before unpacking.Reproduces with any CUDA input when
cuda=Trueorcuda_mode="all".